Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't boot from an ISO if Talos is installed #9232

Closed
Tracked by #8484
smira opened this issue Aug 27, 2024 · 0 comments · Fixed by #9244
Closed
Tracked by #8484

don't boot from an ISO if Talos is installed #9232

smira opened this issue Aug 27, 2024 · 0 comments · Fixed by #9244
Assignees
@frezbo

Comments

@smira
Copy link
Member

smira commented Aug 27, 2024 •
edited
Loading

Add a kernel arg, and add it to the ISO boot so that if Talos detects being already installed, and the arg is present, Talos boot process halts without proceeding further showing diagnostics.

This prevents the case of forgetting to remove the ISO.
@smira smira mentioned this issue Aug 27, 2024
Closed
@smira smira mentioned this issue Aug 29, 2024
Merged
frezbo added a commit to frezbo/talos that referenced this issue Aug 30, 2024
@frezbo
chore: pause sequencer when talos installed and iso booted
307e9eb 
Pause sequencer till the boot timeout if talos is booted from ISO/PXE, but
an existing talos is installed to disk and
`talos.iso.boot.halt_if_installed` kernel argument is set.

Fixes: siderolabs#9232

Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo added a commit to frezbo/talos that referenced this issue Aug 30, 2024
@frezbo
chore: pause sequencer when talos installed and iso booted
7a94ce9 
Pause sequencer till the boot timeout if talos is booted from ISO/PXE, but
an existing talos is installed to disk and
`talos.iso.boot.halt_if_installed` kernel argument is set.

Fixes: siderolabs#9232

Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo added a commit to frezbo/talos that referenced this issue Aug 30, 2024
@frezbo
chore: pause sequencer when talos installed and iso booted
576b6c2 
Pause sequencer till the boot timeout if talos is booted from ISO/PXE, but
an existing talos is installed to disk and
`talos.iso.boot.halt_if_installed` kernel argument is set.

Fixes: siderolabs#9232

Signed-off-by: Noel Georgi <git@frezbo.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@frezbo frezbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: pause sequencer when talos installed and iso booted frezbo/talos
2 participants
@smira @frezbo