fix: check for existence of dhcp6 FQDN first #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
Check that dhcpv6.Options.FQDN() is not nil before trying to use it. This fixes DHCPv6 on GCP. Signed-off-by: Seán C McCord <ulexus@gmail.com>
Ulexus
force-pushed
the
gcp-dhcp6-fix
branch
from
946712b
to
b1b6d61
Compare
smira
approved these changes
Sep 24, 2021
|
/m --ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that dhcpv6.Options.FQDN() is not nil before trying to use it.
This fixes DHCPv6 on GCP.
Signed-off-by: Seán C McCord ulexus@gmail.com
Pull Request
What? (description)
Why? (reasoning)
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)This change is