Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update etcd to 3.5.3 #5344

Merged
merged 1 commit into from
Apr 14, 2022
Merged

feat: update etcd to 3.5.3 #5344

merged 1 commit into from
Apr 14, 2022

Conversation

smira
Copy link
Member

@smira smira commented Apr 13, 2022

See https://github.com/etcd-io/etcd/releases/tag/v3.5.3

This release should contain a fix for data consistency issue when etcd
is killed under high load.

Signed-off-by: Andrey Smirnov andrey.smirnov@talos-systems.com


This change is Reviewable

@smira smira added this to the v1.1 milestone Apr 13, 2022
Copy link
Member

@frezbo frezbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to disable the check we added earlier, i think i saw it's default now (have to confirm)

@smira
Copy link
Member Author

smira commented Apr 13, 2022

do we need to disable the check we added earlier, i think i saw it's default now (have to confirm)

I believe it's not default in 3.5, but I might be wrong

@frezbo
Copy link
Member

frezbo commented Apr 14, 2022

do we need to disable the check we added earlier, i think i saw it's default now (have to confirm)

I believe it's not default in 3.5, but I might be wrong

Should we set this experimental-corrupt-check-time too etcd-io/etcd#9190 (comment)

See https://github.com/etcd-io/etcd/releases/tag/v3.5.3

This release should contain a fix for data consistency issue when etcd
is killed under high load.

Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
@smira
Copy link
Member Author

smira commented Apr 14, 2022

Should we set this experimental-corrupt-check-time too etcd-io/etcd#9190 (comment)

I'm concerned with the performance implications of that, and etcd maintainers say it's significant for big deployments.

@smira
Copy link
Member Author

smira commented Apr 14, 2022

/m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants