fix: decoding config document with wrong apiVersion #8285
Merged
+148
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes siderolabs#8270 The base bug was that the registry will return `nil` `ConfigDocument` if the version is not registered for a kind, which would result into weird config decoding errors. Add more unit-tests, while at it, also add more fuzzing samples. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/config-document-wrong-kind
branch
from
54011a2
to
013e130
Compare
frezbo
approved these changes
Feb 8, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8270
The base bug was that the registry will return
nilConfigDocumentif the version is not registered for a kind, which would result into weird config decoding errors.Add more unit-tests, while at it, also add more fuzzing samples.