chore: account for resource sorting in dns upstream resource #9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
force-pushed
the
dns-upstream-fix
branch
from
951f781
to
8ee540e
Compare
utkuozdemir
approved these changes
Sep 12, 2024
DmitriyMV
force-pushed
the
dns-upstream-fix
branch
from
8ee540e
to
d2193cd
Compare
@frezbo agree. done. |
`List` returns a sorted (by id) list of resources. This doesn't work when the order of dns upstreams is important. Because of that add an `Idx` field to the "DNSUpstreams.net.talos.dev" resource, so we can preserve order. Fixes siderolabs#9274 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
force-pushed
the
dns-upstream-fix
branch
from
d2193cd
to
79cd031
Compare
smira
approved these changes
Sep 12, 2024
Unix4ever
approved these changes
Sep 12, 2024
frezbo
approved these changes
Sep 12, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listreturns a sorted (by id) list of resources. This doesn't work when the order of dns upstreams is important. Because of that add anIdxfield to the "DNSUpstreams.net.talos.dev" resource, so we can preserve order.Fixes #9274