PromisePoolCluster missing functionality #1381
Comments
TuckerWhitehouse
added a commit
to TuckerWhitehouse/node-mysql2
that referenced
this issue
Sep 5, 2024
The implementation of `PromisePoolCluster#getConnection` does not match the capabilities of `PoolCluster#getConnection` nor the definition in `promise.d.ts`. This change corrects this by adding the missing `pattern` and `selector` parameters which are passed through to the underlying method. Fixes sidorares#1381 Note: I may have missed them, but I didn't see any tests for PromisePoolCluster to update or add to with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tried to use the PromisePoolCluster implementation that was recently included.
It appears to be missing at least the
removeinherited event. Not sure if there are others.It also doesn't support passing a pattern or selector to
getConnection.Seems like you maybe be able to workaround the first by using
promisePoolCluster.poolCluster.on('remove'...And I suppose you can always workaround the second by refactoring your code to call
.of(pattern, selector), but it seems like these should be added to match the documentation for PoolCluster.The text was updated successfully, but these errors were encountered: