Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More complete way of adding typings for the Server module #1606

Merged
merged 5 commits into from
Aug 13, 2022
Merged

More complete way of adding typings for the Server module #1606

merged 5 commits into from
Aug 13, 2022

Conversation

jmordica
Copy link
Contributor

  • Conformed to the way typings are being added currently in the project
  • Fixed an issue importing PrepareStatementInfo (while we're at it)

@sidorares
Copy link
Owner

not sure why https://github.com/sidorares/node-mysql2/actions/workflows/code-coverage.yml is still failing, I disabled in manually

Could you add some typings unit tests for types covered in this pr? ( And perhaps ones discussed in #1584 (comment) )

@jmordica
Copy link
Contributor Author

Looks like checks are failing because the package-lock.json isn't synced with the package.json. I can npm install and add the package-lock.json

@jmordica
Copy link
Contributor Author

Now that the actual errors are fixed related to typings, i'll add the test for the Server typings.

@jmordica
Copy link
Contributor Author

@sidorares I've added a new test environment for typings specifically and went ahead and included the Server module. So going forward, anyone that creates new typings will be encouraged to add a test in typings/test and modify the tests.json.

Let me know if this seems over-engineered or if you have any questions. Based on your response, I can also add proper tests for the changes in PR #1584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants