Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
In
package.json
, add the scripttest:tsc-build
, allowing local testing before committing newPRs
:In
.github/workflows/ci-tsc-build.yml
, runs the commandnpm run test:tsc-build
when newPRs
are submittedcode 0
tsc
build command fails, it will print the build errors and exit withcode 1
.github/workflows/ci-linux.yml
main
branch insteadmaster
, but I kept by default like all the otherCI
patterns 🥷🏻In
test/tsc-build/index.ts
, only imports themysql
,mysql/promise
and export themIn
test/tsc-build/tsconfig.json
, reproduces the almost options from originaltsconfig.json
, but:skipLibCheck
tofalse
Important
CI
has a single purpose which is to test the TypeScript build like an external moduletypings
incompatibilities beforePRs
are mergedTests
npm run test:tsc-build
CI
, I cloned (not forked) themaster
to a private repository and played between valid and invalidsPRs
🥷🏻fork