Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pattern and selector to PromisePoolCluster#getConnection #3017

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add pattern and selector to PromisePoolCluster#getConnection #3017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,10 +451,10 @@
inheritEvents(poolCluster, this, ['warn', 'remove']);
}

getConnection() {
getConnection(pattern, selector) {
const corePoolCluster = this.poolCluster;
return new this.Promise((resolve, reject) => {
corePoolCluster.getConnection((err, coreConnection) => {
corePoolCluster.getConnection(pattern, selector, (err, coreConnection) => {

Check warning on line 457 in promise.js

View check run for this annotation

Codecov / codecov/patch

promise.js#L457 

Added line #L457 was not covered by tests
if (err) {
reject(err);
} else {
Expand Down
Loading