feat(PoolCluster): implemented restoreNodeTimeout

[Lupennat]

The pull request enables support for the poolCluster's restoreNodeTimeout option, which should resolve the issue #2315.

[codecov]

Codecov Report

Attention: Patch coverage is 97.74436% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.45%. Comparing base (e8fdad7) to head (df0b318).
Report is 25 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/pool_cluster.js	97.70%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage   87.99%   88.45%   +0.45%     
==========================================
  Files          83       83              
  Lines       12985    13067      +82     
  Branches     1366     1392      +26     
==========================================
+ Hits        11426    11558     +132     
+ Misses       1559     1509      -50     

Flag	Coverage Δ
compression-0	87.84% <97.74%> (-0.15%)	⬇️
compression-1	88.21% <97.74%> (+0.22%)	⬆️
tls-0	87.84% <97.74%> (?)
tls-1	88.02% <97.74%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wellwelwel]

Thanks, @Lupennat! I consider this to be a feat: rather than a fix:, since it's a new feature for MySQL2. What do you think? 🤝

I noticed that a test was changed (test/unit/pool-cluster/test-restore.test.cjs) for this new feature. December is usually a bit of a rush, but as soon as possible, to avoid an unexpected breaking change, I'd just like to run a few local tests before merging 🙋🏻‍♂️

[Lupennat]

I initially thought it was a fix, as the implementation was incomplete. However, I don't see any issues with identifying it as a feat. Please let me know if I need to make any changes to the pull request.
I've added new tests and modified what you pointed out, as this comment was present in the test.

// TODO: RestoreNodeTimeout is currently unsupported.

Most of the tests are simply porting the existing ones from the mysql project.
I have performed the tests locally and I have not noticed any problems, however I await your feedback in case there is anything else to add/modify.

[wellwelwel]

Thanks for clarifying 🙋🏻‍♂️

I've looked at the node-mysql implementation and it looks good to me 🤝