feat(core/dropdown-item): mark dropdown-item as internal event (#761)

siemens · Sep 14, 2023 · b9d4804 · b9d4804
1 parent a61701e
commit b9d4804
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 35 deletions.
diff --git a/BREAKING_CHANGES.md b/BREAKING_CHANGES.md
@@ -2,6 +2,10 @@
 
 ## v2.0.0
 
+### `ix-dropdown-item` remove 'itemClick' event
+
+Remove `itemClick` event use native `click` event instead.
+
 ### `ix-event-list-item` remove deprecated props
 
 Remove deprecated props
@@ -20,7 +24,6 @@ Remove deprecated events
 
 - `close`
 
-
 ### Change `itemSelectionChange` event from `ix-select`
 
 Change type of CustomEvent to:

diff --git a/packages/angular/src/components.ts b/packages/angular/src/components.ts
@@ -673,17 +673,11 @@ export class IxDropdownItem {
   constructor(c: ChangeDetectorRef, r: ElementRef, protected z: NgZone) {
     c.detach();
     this.el = r.nativeElement;
-    proxyOutputs(this, this.el, ['itemClick']);
   }
 }
 
 
-export declare interface IxDropdownItem extends Components.IxDropdownItem {
-  /**
-   * Click on item
-   */
-  itemClick: EventEmitter<CustomEvent<HTMLIxDropdownItemElement>>;
-}
+export declare interface IxDropdownItem extends Components.IxDropdownItem {}
 
 
 @ProxyCmp({

diff --git a/packages/core/component-doc.json b/packages/core/component-doc.json
@@ -3878,17 +3878,7 @@
           "docsTags": []
         }
       ],
-      "events": [
-        {
-          "event": "itemClick",
-          "detail": "HTMLIxDropdownItemElement",
-          "bubbles": true,
-          "cancelable": true,
-          "composed": true,
-          "docs": "Click on item",
-          "docsTags": []
-        }
-      ],
+      "events": [],
       "styles": [],
       "slots": [],
       "parts": [],

diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts
@@ -3868,9 +3868,6 @@ declare namespace LocalJSX {
           * Label of dropdown item
          */
         "label"?: string;
-        /**
-          * Click on item
-         */
         "onItemClick"?: (event: IxDropdownItemCustomEvent<HTMLIxDropdownItemElement>) => void;
         "suppressChecked"?: boolean;
     }

diff --git a/packages/core/src/components/dropdown-item/dropdown-item.tsx b/packages/core/src/components/dropdown-item/dropdown-item.tsx
@@ -51,19 +51,13 @@ export class DropdownItem {
    */
   @Prop() checked = false;
 
-  /**
-   * @internal
-   */
+  /** @internal */
   @Prop() isSubMenu = false;
 
-  /**
-   * @internal
-   */
+  /** @internal */
   @Prop() suppressChecked = false;
 
-  /**
-   * Click on item
-   */
+  /** @internal */
   @Event() itemClick: EventEmitter<HTMLIxDropdownItemElement>;
 
   /**

diff --git a/packages/documentation/docs/controls/dropdown.md b/packages/documentation/docs/controls/dropdown.md
@@ -89,7 +89,3 @@ frameworks={{
 ### Props
 
 <ItemProps />
-
-### Events
-
-<ItemEvents />