fix(aggrid): remove box shadow from editor cells (#600)

siemens · Jun 27, 2023 · e3821b3 · e3821b3
1 parent 69e69c0
commit e3821b3
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 1 deletion.
diff --git a/packages/aggrid/scss/ix-aggrid.scss b/packages/aggrid/scss/ix-aggrid.scss
@@ -85,6 +85,10 @@
     }
   }
 
+  .ag-cell-inline-editing {
+    box-shadow: none;
+  }
+
   .ag-header-cell-resize::after {
     transition: background-color 250ms linear;
   }

diff --git a/packages/aggrid/src/components/tests/aggrid.e2e.ts b/packages/aggrid/src/components/tests/aggrid.e2e.ts
@@ -27,6 +27,15 @@ regressionTest.describe('aggrid', () => {
     expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
   });
 
+  regressionTest('editor', async ({ page }) => {
+    await page.goto('basic.html');
+
+    const editorCellHandle = await page.waitForSelector('.ag-cell-not-inline-editing[col-id="price"]');
+    await editorCellHandle.dblclick();
+
+    expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
+  });
+
   regressionTest('pagination', async ({ page }) => {
     await page.goto('pagination.html');
     expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();

diff --git a/...aggrid.e2e.ts-snapshots/aggrid-editor-1-chromium---theme-classic-dark-linux.png b/...aggrid.e2e.ts-snapshots/aggrid-editor-1-chromium---theme-classic-dark-linux.png
diff --git a/...ggrid.e2e.ts-snapshots/aggrid-editor-1-chromium---theme-classic-light-linux.png b/...ggrid.e2e.ts-snapshots/aggrid-editor-1-chromium---theme-classic-light-linux.png
diff --git a/packages/aggrid/src/components/tests/basic.html b/packages/aggrid/src/components/tests/basic.html
@@ -33,7 +33,7 @@
         const columnDefs = [
           { field: 'make', resizable: true, checkboxSelection: true },
           { field: 'model', resizable: true, sortable: true, filter: true },
-          { field: 'price', resizable: true },
+          { field: 'price', resizable: true, editable: true },
         ];
 
         const rowData = [