Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/modal): remove dialog on escape #1016

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

nuke-ellington
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: IX-699

What is the new behavior?

  • Dialog will get removed form top layer on escape
  • VRT ensures dialog is not visiable (empty screenshot) maybe debatabel test :)

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Dec 20, 2023
@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Dec 20, 2023
@nuke-ellington nuke-ellington marked this pull request as draft December 22, 2023 16:33
@nuke-ellington nuke-ellington marked this pull request as ready for review January 10, 2024 13:24
@danielleroux danielleroux merged commit 3b69aba into main Jan 15, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/modal-key-listener branch January 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants