Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/upload): replace class icons with ix-icon #1022

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

danielleroux
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: Closes #1019

🆕 What is the new behavior?

Replace glyph icon with ix-icon component

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (yarn docs)
  • 🧪 Unit tests were added/updated and pass (yarn test)
  • 📸 Visual regression tests were added/updated and pass (yarn visual-regression)
  • 🧐 Static code analysis passes (yarn lint)
  • 🏗️ Successful compilation (yarn build, changes pushed)

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Dec 22, 2023
@danielleroux danielleroux added this to the 2.1.0 milestone Dec 22, 2023
@danielleroux danielleroux linked an issue Dec 22, 2023 that may be closed by this pull request
@danielleroux danielleroux merged commit 9198d31 into main Jan 8, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/1019-upload-state-fix branch January 8, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In "UPLOAD_SUCCESSED" state, text is showing but icon is not
2 participants