Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aggrid checkbox sizing #1067

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

robert-wettstaedt
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Ag-grid allows selecting rows of a table by adding checkboxes to the start of a row. The actual <input type="checkbox" /> element is only about half the size of the visible checkbox making it difficult to click the checkbox in order to select a row.

Example: https://ix.siemens.io/docs/grid/#usage

What is the new behavior?

The size of the <input type="checkbox" /> element now corresponds to the visible size of the checkbox.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Manually clicking the checkbox

Other information

Before:
before

After:
after

@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Feb 6, 2024
@nuke-ellington nuke-ellington added pull request affects patch version The pull request affects only patch version type: bug Something isn't working labels Feb 6, 2024
@nuke-ellington nuke-ellington merged commit 317e009 into siemens:main Feb 6, 2024
6 checks passed
@robert-wettstaedt robert-wettstaedt deleted the patch-1 branch February 7, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants