Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/burger-menu): a11y expand state #1112

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Feb 22, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • Before the chevron button was flipped via rotation which caused the aria-label to be wrong while expanded
  • Now the icon will get swapped instead and the aria label will get computed anew everytime the menu toggles

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Feb 22, 2024
@nuke-ellington nuke-ellington added this to the 2.1.1 milestone Feb 22, 2024
@danielleroux danielleroux changed the title Fix/burger menu aria label fix(core/burger-menu): a11y expand state Feb 23, 2024
@danielleroux danielleroux merged commit cd3d033 into main Feb 23, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/burger-menu-aria-label branch February 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants