Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/panes): expanded and slot error #1119

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Feb 23, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When a pane within a layout is initially expanded, it closes upon rendering. Some icons were not displayed correctly, and some paddings were incorrect following certain animations. Moreover, a display issue arose when changing the slot for a pane that was in the process of closing (during its animation phase).

GitHub Issue Number: #1108

What is the new behavior?

The pane now remains expanded. In addition, the minor UI issues have been resolved, along with a problem that occurred when changing a slot while a pane was closing.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Manual tests.

Other information

@jul-lam jul-lam self-assigned this Feb 23, 2024
@jul-lam jul-lam added this to the 2.1.1 milestone Feb 23, 2024
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Feb 23, 2024
@danielleroux danielleroux merged commit 4d3f895 into main Feb 26, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/pane-expanded branch February 26, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants