fix(core/panes): expanded and slot error #1119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When a pane within a layout is initially expanded, it closes upon rendering. Some icons were not displayed correctly, and some paddings were incorrect following certain animations. Moreover, a display issue arose when changing the slot for a pane that was in the process of closing (during its animation phase).
GitHub Issue Number: #1108
What is the new behavior?
The pane now remains expanded. In addition, the minor UI issues have been resolved, along with a problem that occurred when changing a slot while a pane was closing.
Does this introduce a breaking change?
Testing
Manual tests.
Other information