Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu): fix theme switching icon #1121

Merged
merged 9 commits into from
Feb 26, 2024
Merged

fix(core/menu): fix theme switching icon #1121

merged 9 commits into from
Feb 26, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Feb 26, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently the icon for the theme switching is the light bulb, which is normally used for idea or insights.

GitHub Issue Number: N/A

What is the new behavior?

The icon has changed to "light-dark" in order to make it more clear.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a visual regression test.

@danielleroux danielleroux added this to the 2.1.1 milestone Feb 26, 2024
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Feb 26, 2024
@danielleroux danielleroux merged commit 0def517 into main Feb 26, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/406-menu branch February 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants