Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/chip): adjust width on outline variant #1312

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Jun 6, 2024

💡 What is the current behavior?

  • The outline variant with the same content is 2px widder than there non outline counterpart

GitHub Issue Number: Closes #1161

🆕 What is the new behavior?

  • outline and normal variant have the same width
  • same applies for the icon variant
  • NOTE: pills also utilizing the chip mixins, accordingly the chips have also been adapted!

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: 67ef74d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux added this to the 2.x.x milestone Jun 11, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon outline is narrower than non outline icon

@danielleroux danielleroux merged commit f4eeebf into main Jun 14, 2024
13 checks passed
@danielleroux danielleroux deleted the fix/1105-chip branch June 14, 2024 14:18
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chip is larger with outline property
3 participants