Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/datetime-picker): responsiveness, strict typing, spacing #1558

Merged
merged 26 commits into from
Nov 21, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Nov 11, 2024

💡 What is the current behavior?

  • time picker takes not full width on mobile
  • spacing is not correct on mobile
  • chevron-up / chevron-left is used

GitHub Issue Number: Closes #697, [IX-1614]

🆕 What is the new behavior?

  • time picker takes full width on mobile
  • adapted spacing
  • bottom margin from the time-picker = 2rem (This was somewhat challenging to achieve because there was no option to edit them externally. As a solution, they were adapted within the component to reflect the changes in the datetime-picker while preserving the spacing in the component. Because of this some spacings have been adapted in the time-picker)
  • chevron-up-small / chevron-left-small is used

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 9dcde2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft November 11, 2024 12:18
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Report of strict check

src/components/date-picker/date-picker.tsx
  • src/components/date-picker/date-picker.tsx(384,26): error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.: error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.
  • src/components/date-picker/date-picker.tsx(579,28): error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.: error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.
  • src/components/date-picker/date-picker.tsx(582,35): error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.: error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.

@matthiashader matthiashader marked this pull request as ready for review November 19, 2024 09:03
@matthiashader matthiashader marked this pull request as draft November 20, 2024 11:11
@matthiashader matthiashader marked this pull request as ready for review November 20, 2024 11:49
Copy link

sonarcloud bot commented Nov 21, 2024

@nuke-ellington nuke-ellington dismissed danielleroux’s stale review November 21, 2024 09:33

Changes where implemented

@nuke-ellington nuke-ellington merged commit 8e72ec8 into main Nov 21, 2024
15 checks passed
@nuke-ellington nuke-ellington deleted the fix/1614-datetime-picker branch November 21, 2024 09:34
This was referenced Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile support for date time picker
3 participants