Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/icon-button): implement a11y features for icon-button #502

Merged
merged 19 commits into from
Nov 15, 2023

Conversation

jg0815
Copy link
Contributor

@jg0815 jg0815 commented May 2, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Implemented new property 'ariaLabel' for the icon-button component, which is required as an accessibility label for the respective icon used.
  • Implemented the required ARIA-attribute settings for the icon-button component (aria-label).
  • Implemented fallback icon lables based on the icon names from the iX-build-in icon library (EN-language only).
  • Added required attribute 'disabled' for the <button> element.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label May 12, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 12, 2023
@danielleroux danielleroux modified the milestones: 1.6.0, 1.7.0 May 26, 2023
@danielleroux danielleroux modified the milestones: 1.7.0, 2.0.0 Sep 8, 2023
@danielleroux danielleroux removed this from the 2.0.0 milestone Sep 25, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jg0815 question regarding label name in review comment

packages/core/src/components/icon-button/icon-button.tsx Outdated Show resolved Hide resolved
@nuke-ellington nuke-ellington merged commit 4f7275a into main Nov 15, 2023
7 checks passed
@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Nov 16, 2023
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@danielleroux danielleroux deleted the fix/icon-button-accessibility branch September 5, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants