Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/modal): border-radius value #517

Merged
merged 3 commits into from
May 11, 2023
Merged

fix(core/modal): border-radius value #517

merged 3 commits into from
May 11, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #509

What is the new behavior?

  • Changed border-radius value to correct value from Figma

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also try to improve the visual regression test first, because the test has to fail without updating the image refs.

Maybe it is necessary to adapt the screenshot target area to reduce the compared pixel ratio.

packages/core/src/components/modal/modal.scss Outdated Show resolved Hide resolved
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label May 11, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 11, 2023
@danielleroux danielleroux merged commit 3f3d305 into main May 11, 2023
@danielleroux danielleroux deleted the fix/modal-corners branch May 11, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants