Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/empty-state): implement empty state #523

Merged
merged 8 commits into from
May 15, 2023
Merged

feat(core/empty-state): implement empty state #523

merged 8 commits into from
May 15, 2023

Conversation

christopher-bergwein-siemens
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Empty state component is added with three different layouts "large", "compact" and "compactBreak"

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label May 11, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 11, 2023
danielleroux
danielleroux approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit efc3f7c into main May 15, 2023
@danielleroux danielleroux deleted the feat/empty-state branch May 15, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@christopher-bergwein-siemens @danielleroux