Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/drawer): start show true #652

Merged
merged 5 commits into from
Jul 27, 2023
Merged

fix(core/drawer): start show true #652

merged 5 commits into from
Jul 27, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: closes #647

What is the new behavior?

  • Now when show prop starts true, drawer starts opened correctly

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux merged commit 56c730b into main Jul 27, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jul 27, 2023
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Jul 27, 2023
@danielleroux danielleroux deleted the fix/drawer branch September 5, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer is not shown if initialized with [show]=true
2 participants