Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/date-dropdown): new date-dropdown component #797

Merged
merged 30 commits into from
Nov 13, 2023
Merged

feat(core/date-dropdown): new date-dropdown component #797

merged 30 commits into from
Nov 13, 2023

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Oct 3, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • date range selection via dropdown
  • uses dayjs
  • user can pass custom ranges

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader changed the title feat(core/date-dropdown): initial commit feat(core/date-dropdown): new date-dropdown component Oct 3, 2023
matthiashader and others added 15 commits October 3, 2023 13:08
@matthiashader
Merge branch 'bug/nested-dropdown' into feat/date-dropdown
2f477ba
@matthiashader
feat(core/date-dropdown): initial commit
7f65c2f
@danielleroux
fix: add dayjs to mount point
19c87a2
@danielleroux
test: remove default dayjs
877ddf2
@danielleroux
test: load dayjs script during beforeEach
9bacdd0
@matthiashader
feat(core/date-dropdown): added support for updates outside the compo…
5908a60 
…nent, fixed tests
@matthiashader
feat(core/date-dropdown): yarn build + package dependencies
0cc97f3
@matthiashader
feat(core/date-dropdown): async test fixes
aa38627
@matthiashader
Merge remote-tracking branch 'origin/main' into feat/date-dropdown
8017ec2 
# Conflicts:
#	packages/core/src/components/dropdown/dropdown.tsx
@matthiashader
feat(core/date-dropdown): yarn-lock
5d928ef
@matthiashader
feat(core/date-dropdown): fix
d68ab2b
@danielleroux
build: remove wrong npm registry
46caa1b
@matthiashader
feat(core/date-dropdown): fix
2236a01
@matthiashader
feat(core/date-dropdown): changed naming
ebf54d3
@matthiashader
feat(core/date-dropdown): config change in test app
5e63606
@matthiashader matthiashader marked this pull request as draft October 17, 2023 08:16
@danielleroux danielleroux added this to the 2.1.0 milestone Oct 20, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Oct 20, 2023
@matthiashader matthiashader marked this pull request as ready for review October 24, 2023 06:47
nuke-ellington
nuke-ellington requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressing 'Enter' when 'Custom..' is selected will close the dropdown. Datepicker should open instead.

nuke-ellington
nuke-ellington previously approved these changes Nov 8, 2023
View reviewed changes
@nuke-ellington nuke-ellington merged commit 710b356 into main Nov 13, 2023
7 checks passed
@matthiashader matthiashader linked an issue Nov 20, 2023 that may be closed by this pull request
Inline Datetime picker #536
Closed
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
@matthiashader @lzeiml
@danielleroux @nuke-ellington
feat(core/date-dropdown): new date-dropdown component (#797)
3d8d804 
Co-authored-by: lzeiml <lukas.zeiml@gmail.com>
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@robert-wettstaedt
Copy link
Contributor

robert-wettstaedt commented Feb 12, 2024 •
edited
Loading

Hello, are there any plans on when this new feature is going to be released in a new version? It's been merged for almost 3 months now and I would like to use this feature.

@matthiashader
Copy link
Collaborator Author

@robert-wettstaedt sorry for keeping you waiting. This component was released with v2.1.0

@danielleroux danielleroux deleted the feat/date-dropdown branch September 5, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Inline Datetime picker
5 participants
@matthiashader @robert-wettstaedt @nuke-ellington @danielleroux @lzeiml