Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/input-group): add padding left for error image #838

Merged
merged 4 commits into from
Oct 20, 2023
Merged

fix(core/input-group): add padding left for error image #838

merged 4 commits into from
Oct 20, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Oct 11, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

What is the new behavior?

  • Fix padding if used inside a form validation
  • Add ellipsis to handle input overflow

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Oct 11, 2023
@danielleroux danielleroux mentioned this pull request Oct 11, 2023
Closed
nuke-ellington
nuke-ellington previously approved these changes Oct 12, 2023
View reviewed changes
@danielleroux danielleroux marked this pull request as draft October 12, 2023 07:44
@danielleroux danielleroux marked this pull request as ready for review October 17, 2023 08:43
@danielleroux danielleroux merged commit fa44ab5 into main Oct 20, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/input-group-validation-padding branch October 20, 2023 12:41
@danielleroux danielleroux added this to the 2.1.0 milestone Oct 20, 2023
@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
nuke-ellington pushed a commit that referenced this pull request Nov 20, 2023
@danielleroux @nuke-ellington
fix(core/input-group): add padding left for error image (#838)
09f1da1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.

Input padding keeps increasing after deleting input text
2 participants
@danielleroux @nuke-ellington