Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/button): prevent interaction of ix-icon #839

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fix(core/button): prevent interaction of ix-icon #839

merged 3 commits into from
Oct 12, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: Closes #795

What is the new behavior?

  • Prevent interaction with ix-icon component

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Oct 11, 2023
@danielleroux danielleroux changed the title fix(core/button): prevent ix-icon interaction of ix-icon fix(core/button): prevent interaction of ix-icon Oct 11, 2023
@danielleroux danielleroux mentioned this pull request Oct 11, 2023
Closed
@danielleroux @nuke-ellington
fix: typo
43514d9 
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@danielleroux danielleroux merged commit a0bd2af into main Oct 12, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/button-icon-tooltip branch October 12, 2023 13:24
@danielleroux danielleroux added this to the 2.1.0 milestone Oct 20, 2023
@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
@danielleroux @nuke-ellington
fix(core/button): prevent interaction of ix-icon (#839)
13d53c0 
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.

ix-icon-button tooltip show the name of the icon and not the content of the title field
2 participants
@danielleroux @nuke-ellington