Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/tree): add undefined check to disconnected callback #867

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(core/tree): add undefined check to disconnected callback #867

merged 1 commit into from
Oct 23, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #866

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the type: bug Something isn't working label Oct 23, 2023
@danielleroux danielleroux added this to the 2.1.0 milestone Oct 23, 2023
@danielleroux danielleroux merged commit 38e5ca6 into main Oct 23, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/tree-destroy-undefined branch October 23, 2023 08:02
@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
nuke-ellington pushed a commit that referenced this pull request Nov 20, 2023
@danielleroux @nuke-ellington
fix(core/tree): add undefined check to disconnected callback (#867)
bf89cea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@danielleroux @nuke-ellington