Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: chip styleguide #904

Merged
merged 11 commits into from
Nov 22, 2023
Merged

docs: chip styleguide #904

merged 11 commits into from
Nov 22, 2023

Conversation

gyoengyiszabo
Copy link
Contributor

Pull request checklist

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
packages/documentation/docs/controls/_chip_styleguide.md Outdated Show resolved Hide resolved
linstedt
linstedt previously approved these changes Nov 17, 2023
@linstedt
Copy link
Collaborator

@nuke-ellington Could you please review the changes? Also there are some small mistakes in the code usage description which I didn't know how to fix. For the properties background and color, the text talks about pills not chips.

After your review, I will also ask Jennie for an editorial review thus you can focus on content and less language improvements.

@linstedt linstedt changed the title Docs: chip styleguide docs: chip styleguide Nov 17, 2023
@nuke-ellington
Copy link
Collaborator

@nuke-ellington Could you please review the changes? Also there are some small mistakes in the code usage description which I didn't know how to fix. For the properties background and color, the text talks about pills not chips.

After your review, I will also ask Jennie for an editorial review thus you can focus on content and less language improvements.

Done - UX writing can have a look at it. Let me know when it is ready for merge!

@nuke-ellington nuke-ellington marked this pull request as ready for review November 21, 2023 08:40
@nuke-ellington nuke-ellington removed the request for review from tokyojen November 21, 2023 08:40
@nuke-ellington nuke-ellington marked this pull request as draft November 21, 2023 08:41
@linstedt linstedt removed the request for review from tokyojen November 21, 2023 11:42
@linstedt linstedt marked this pull request as ready for review November 21, 2023 11:43
@linstedt
Copy link
Collaborator

@nuke-ellington Pull request is ready

@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Nov 22, 2023
@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Nov 22, 2023
@nuke-ellington nuke-ellington merged commit 6943e22 into main Nov 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants