Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/group): fixed shift on overflow text #916

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Nov 14, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • selected indicator gets shifted if the texts overflows and the ellipsis are shown

GitHub Issue Number: #913

What is the new behavior?

  • selected indicator has the same width on overflow and on non-overflow

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader self-assigned this Nov 14, 2023
@matthiashader matthiashader linked an issue Nov 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test the overflow via visual-regression?

@matthiashader
Copy link
Collaborator Author

Should we test the overflow via visual-regression?

Yeah, I think it wouldn't hurt the application.

@nuke-ellington nuke-ellington merged commit f54ae23 into main Nov 15, 2023
7 checks passed
@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Nov 15, 2023
@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group header selection indicator border moves unexpectedly
2 participants