Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/pill): fix custom outline variant and add variant examples #968

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

nuke-ellington
Copy link
Collaborator

…o documentation

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #958

What is the new behavior?

  • Custom variant outline will now be shown
  • Variant examples added

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added the pull request affects minor version The pull request affects only minor version label Dec 5, 2023
@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Dec 5, 2023
@nuke-ellington nuke-ellington merged commit c364aab into main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant