Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Sidepanel Component #989

Merged
merged 82 commits into from
Feb 9, 2024
Merged

New Sidepanel Component #989

merged 82 commits into from
Feb 9, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Dec 11, 2023 •
edited by jul-lam
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • Implemented Panes

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader self-assigned this Dec 11, 2023
@matthiashader matthiashader marked this pull request as draft December 12, 2023 11:30
@danielleroux danielleroux added this to the 2.1.0 milestone Dec 21, 2023
danielleroux
danielleroux requested changes Jan 8, 2024
View reviewed changes
packages/core/src/components/side-pane-group/side-pane-group.tsx Outdated Show resolved Hide resolved
packages/core/src/components/side-pane-group/side-pane-group.tsx Outdated Show resolved Hide resolved
packages/core/src/components/side-pane-group/side-pane-group.tsx Outdated Show resolved Hide resolved
packages/core/src/components/side-pane-group/side-pane-group.tsx Outdated Show resolved Hide resolved
packages/core/src/components/side-pane-group/side-pane-group.tsx Outdated Show resolved Hide resolved
packages/angular-test-app/src/preview-examples/side-pane-group-floating.ts Outdated Show resolved Hide resolved
packages/angular-test-app/src/preview-examples/side-pane-group-inline.ts Outdated Show resolved Hide resolved
packages/angular-test-app/src/preview-examples/side-pane-group-preview-content.ts Outdated Show resolved Hide resolved
packages/core/src/components/side-pane/side-pane.tsx Outdated Show resolved Hide resolved
packages/core/src/components/side-pane-content-area/side-pane-content-area.tsx Outdated Show resolved Hide resolved
danielleroux
danielleroux reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding and remove ix-side-pane component will break the layouting, add cause the animation to play:

Screen.Recording.2024-01-08.at.15.33.52.mov

danielleroux
danielleroux previously requested changes Jan 31, 2024
View reviewed changes
packages/core/src/components/playground/playground.tsx Outdated Show resolved Hide resolved
packages/core/src/components/pane/pane.tsx Outdated Show resolved Hide resolved
packages/core/src/components/pane/pane.tsx Outdated Show resolved Hide resolved
packages/core/src/components/pane/pane.tsx Outdated Show resolved Hide resolved
packages/core/src/components/pane/pane.tsx Outdated Show resolved Hide resolved
packages/core/src/components/pane/pane.tsx Show resolved Hide resolved
packages/core/src/components/pane/pane.scss Outdated Show resolved Hide resolved
packages/core/src/components/pane-layout/pane-layout.scss Outdated Show resolved Hide resolved
packages/core/src/components/pane-layout/pane-layout.tsx Outdated Show resolved Hide resolved
nuke-ellington
nuke-ellington requested changes Feb 7, 2024
View reviewed changes
packages/documentation/docs/controls/panes.md Outdated Show resolved Hide resolved
packages/core/src/components/pane/pane.tsx Outdated Show resolved Hide resolved
@nuke-ellington nuke-ellington merged commit 0c13d91 into main Feb 9, 2024
6 checks passed
@danielleroux danielleroux deleted the feat/side-panel branch September 5, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jul-lam jul-lam jul-lam left review comments

@nuke-ellington nuke-ellington nuke-ellington approved these changes

@danielleroux danielleroux danielleroux left review comments

Assignees

@matthiashader matthiashader

@jul-lam jul-lam

Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiashader @danielleroux @nuke-ellington @jul-lam