Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last missing pieces for AdditionalExtendedResponse #57

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

dodomorandi
Copy link
Contributor

The feature was almost complete, but there were a few changes to be made in order to fix the serialization/deserialization behavior. A few tests related to the issue have been added.

@dodomorandi dodomorandi added bug Something isn't working enhancement New feature or request labels Aug 19, 2022
@dodomorandi dodomorandi requested a review from lu-zero August 19, 2022 08:47
@dodomorandi dodomorandi self-assigned this Aug 19, 2022
@dodomorandi dodomorandi linked an issue Aug 19, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 19, 2022

Pull Request Test Coverage Report for Build 2901895755

  • 40 of 40 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.638%

Totals Coverage Status
Change from base Build 2901890261: 0.01%
Covered Lines: 9859
Relevant Lines: 10202

💛 - Coveralls

@dodomorandi dodomorandi force-pushed the additional-expected-response branch from 0275c04 to 05839c6 Compare August 22, 2022 07:02
@dodomorandi dodomorandi merged commit 16ef4f1 into master Aug 22, 2022
@dodomorandi dodomorandi deleted the additional-expected-response branch August 22, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdditionalExpectedResponse
3 participants