feat: add missing CoAP vocabulary terms #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
coap-protocol-binding
branch
from
8eaf03c
to
2ca3b0f
Compare
|
It does look good, Somehow this PR notification got chewed by my mailer and I noticed it just today :/ |
lu-zero
reviewed
Jan 30, 2023
| @@ -62,6 +62,19 @@ pub struct Form { | |||
| pub qblockwise: Option<BlockWiseTransferParameters>, | |||
| #[serde(rename = "cov:hopLimit")] | |||
| pub hop_limit: Option<u8>, | |||
| #[serde(rename = "cov:accept")] | |||
| pub accept: Option<u16>, | |||
| #[serde(rename = "cov:contentFormat")] | |||
There was a problem hiding this comment.
We should mention https://www.iana.org/assignments/core-parameters/core-parameters.xhtml#content-formats somewhere, but that does not prevent the patch from landing.
lu-zero
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
cov:contentFormatandcov:acceptfields from the latest CoAP Binding Document version.