Always coredump on crash if we're allowed to #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmjconolly
approved these changes
Jun 28, 2023
V-FEXrt
reviewed
Jun 28, 2023
V-FEXrt
approved these changes
Jun 28, 2023
mmjconolly
reviewed
Jun 29, 2023
| // Make sure we always get core dumps but don't fail | ||
| // if that fails for some reason. | ||
| struct rlimit core_lim; | ||
| getrlimit(RLIMIT_CORE, &core_lim); |
There was a problem hiding this comment.
I'm wondering if we should restore the original limit after we next fork() (where ever that might be), as here we enable core dumps for all payload commands run inside wakebox
There was a problem hiding this comment.
I'm not personally very apposed to getting core dumps for everything but if people want that I can make shim-wake reset the limit or reset it just before invoking shim wake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should just set the limit on the core size to what ever the maximum allowed is. When the size is 0 (often the default on various systems) no core dump will be produced.