Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib: Fix refactor typo #1660

Merged
merged 2 commits into from
Oct 1, 2024
Merged

stdlib: Fix refactor typo #1660

merged 2 commits into from
Oct 1, 2024

Conversation

V-FEXrt
Copy link
Collaborator

@V-FEXrt V-FEXrt commented Oct 1, 2024

I made a typo when refactoring the runners. This change fixes the typo and the subsequent downstream breakages.

ag-eitilt
ag-eitilt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating from external conversation: I didn't see any similar switches in reviewing the diff against v43.1.4.

colinschmidt
colinschmidt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@V-FEXrt V-FEXrt merged commit d38dd06 into master Oct 1, 2024
11 checks passed
@V-FEXrt V-FEXrt deleted the stdlib-fix-bug branch October 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinschmidt colinschmidt colinschmidt approved these changes

@ag-eitilt ag-eitilt ag-eitilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V-FEXrt @colinschmidt @ag-eitilt