Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weak attribute to mcu_api.c #2

Closed
wants to merge 1 commit into from

Conversation

disk91
Copy link

@disk91 disk91 commented May 3, 2024

As the previous commit, it allows to override the api function and not touch the sigfox submodule

As the previous commit, it allows to override the api function and not touch the sigfox submodule
@Ludovic-Lesur
Copy link
Contributor

Thank you @disk91 for this improvement proposal. The __attribute__((weak)) keywork will be added on all functions template on the next versions (library and other repositories which have templates as well).

Meanwhile, most of IDEs feature an exclude from build option, telling the compiler to ignore specific files or folders. If you apply this to the src/manuf folder of the sigfox-ep-lib repository, you can implement your own mcu_api.c and rf_api.c files while keeping the submodule clean.

CedricB31 added a commit that referenced this pull request May 30, 2024
@CedricB31 CedricB31 closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants