use Popen context manager for periodic update process (pypa#2472)

sigma67 · Aug 4, 2023 · bc4fda2 · bc4fda2
1 parent 119c63e
commit bc4fda2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/changelog/2472.bugfix.rst b/docs/changelog/2472.bugfix.rst
@@ -0,0 +1 @@
+Use Popen context manager for periodic update process to prevent ResourceWarning due to unclosed files
diff --git a/src/virtualenv/seed/wheels/periodic_update.py b/src/virtualenv/seed/wheels/periodic_update.py
@@ -220,7 +220,7 @@ def trigger_update(distribution, for_py_version, wheel, search_dirs, app_data, e
     kwargs = {"stdout": pipe, "stderr": pipe}
     if not debug and sys.platform == "win32":
         kwargs["creationflags"] = CREATE_NO_WINDOW
-    process = Popen(cmd, **kwargs)  # noqa: S603
+    process = Popen(cmd, close_fds=True, **kwargs)  # noqa: S603
     logging.info(
         "triggered periodic upgrade of %s%s (for python %s) via background process having PID %d",
         distribution,