Fix parsing of album and views in parse_playlist_items #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse album and views columns as a function of flex column count and is_album property to cater for varying layouts with three and four flex columns
To allow for an easy distinction between owned / editable and community / non-editable playlists,in applications incorporating ytmusicapi, a boolean "own_playlist" dictionary entry is added to playlists based on existing code already identifying this property.
Add thumbnails to episodes for visual rendering in Kodi etc.
|
@sigma67 Please note that the three commits are independent contributions an that there are no dependencies between them whatsoever |
Add unit test for playlist "own_playlist" attribut
sigma67
reviewed
Feb 25, 2024
- rename attribute for own playlists to playlist("owned")
- filter out episode thumbnails with an non-functional URL
|
@fischcode linter is still failing |
Fix test for playlist["owned"]
|
Added a commit to fischcode/ytmusicapi but it fails to show up here ... |
No idea why I had seen useless images for those thumbnails before - maybe Google fixed something to make them work?
sigma67
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse album and views columns as a function of flex column count and is_album property to cater for varying layouts with three and four flex columns