Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode of getting binlog timestamps using mysqlbinlog and go-mysql/replication #584

Merged
merged 8 commits into from
May 14, 2024

Conversation

caffeinated92
Copy link
Collaborator

This PR should fix #579

Contributor Agreement

By submitting this pull request, I agree to the terms outlined in the Contributor Agreement.

@caffeinated92 caffeinated92 self-assigned this May 13, 2024
Copy link
Collaborator

@svaroqui svaroqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello both methods can be needed for example slapos will always prefer using mysqlbinlog , i would rather like a parameter that list all possible options to extract binlog and default to go-mysql as it's the only embedded one. Also it is prefered to have choice as go mysql being implementation of the binlog protocol it could potentialy lag behind protocol changes and we wan't a way out using mysql or mariadb mysqlbinlog

@caffeinated92
Copy link
Collaborator Author

I will add the function and check for the preferences

@caffeinated92 caffeinated92 changed the title Change method of getting binlog timestamps from mysqlbinlog to go-mysql/replication Add mode of getting binlog timestamps using mysqlbinlog and go-mysql/replication May 14, 2024
@caffeinated92
Copy link
Collaborator Author

At first mysqlbinlog has different datetime after parse. But after changing to time.Local, the value is already same with go-mysql (which is the correct value)

@svaroqui svaroqui merged commit 161ef8d into develop May 14, 2024
@caffeinated92 caffeinated92 linked an issue May 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking oldest binlog timestamp returned Err: Failed to parse binary log datetime string.
2 participants