Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang docker to 1.22 #611

Merged
merged 2 commits into from
May 26, 2024
Merged

Bump golang docker to 1.22 #611

merged 2 commits into from
May 26, 2024

Conversation

caffeinated92
Copy link
Collaborator

@caffeinated92 caffeinated92 commented May 26, 2024

Bump dependencies needed after fixing k8s #608

Before:
`
=> [ 4/17] COPY . . 1.9s
=> ERROR [ 5/17] RUN make pro cli 0.7s

[ 5/17] RUN make pro cli:
0.624 env CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v --tags "server" --ldflags " -w -s -X 'github.com/signal18/replication-manager/server.Version=v2.3.30' -X 'github.com/signal18/replication-manager/server.FullVersion=v2.3.30-9-ga4c00a40' -X 'github.com/signal18/replication-manager/server.Build=2024-05-26T08:59:00+0000' -X github.com/signal18/replication-manager/server.WithOpenSVC=ON " -o build/binaries/replication-manager-pro
0.636 go: errors parsing go.mod:
0.636 /go/src/github.com/signal18/replication-manager/go.mod:3: invalid go version '1.22.0': must match format 1.23
0.636 /go/src/github.com/signal18/replication-manager/go.mod:5: unknown directive: toolchain
0.637 make: *** [Makefile:50: pro] Error 1


Dockerfile.dev:10

8 | COPY . .
9 |
10 | >>> RUN make pro cli
11 |
12 | RUN mkdir -p \

ERROR: failed to solve: process "/bin/sh -c make pro cli" did not complete successfully: exit code: 2
`

@caffeinated92
Copy link
Collaborator Author

caffeinated92 commented May 26, 2024

Tested in local
After
sudo docker build . -t throwable -f docker/Dockerfile.dev [+] Building 256.8s (22/22) FINISHED docker:default => [internal] load build definition from Dockerfile.dev 0.1s => => transferring dockerfile: 1.91kB 0.0s => [internal] load metadata for docker.io/library/golang:1.22-bullseye 1.1s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [ 1/17] FROM docker.io/library/golang:1.22-bullseye@sha256:78b171fe51f25b8c3197710f281dacae94759a254e9a486576005f9dadba9e7d 0.0s => [internal] load build context 4.2s => => transferring context: 345.32MB 4.2s => CACHED [ 2/17] RUN mkdir -p /go/src/github.com/signal18/replication-manager 0.0s => CACHED [ 3/17] WORKDIR /go/src/github.com/signal18/replication-manager 0.0s => [ 4/17] COPY . . 2.2s => [ 5/17] RUN make pro cli 103.5s => [ 6/17] RUN mkdir -p /etc/replication-manager /etc/replication-manager/cluster.d /var/lib/replication-manager 0.7s => [ 7/17] RUN cp etc/local/config.toml.docker /etc/replication-manager/config.toml && cp etc/local/masterslave/haproxy/config.toml /etc/replication-manager/ 1.5s => [ 8/17] RUN apt-get update && apt-get -y install mydumper ca-certificates restic mariadb-client mariadb-server mariadb-plugin-spider haproxy libmariadb-d 44.0s => [ 9/17] RUN curl -LO https://github.com/sysown/proxysql/releases/download/v2.5.5/proxysql_2.5.5-debian11_amd64.deb && dpkg -i proxysql_2.5.5-debian11_amd6 9.2s => [10/17] RUN /usr/local/go/bin/go install -v golang.org/x/tools/gopls@latest 25.4s => [11/17] RUN /usr/local/go/bin/go install -v github.com/cweill/gotests/gotests@v1.6.0 6.5s => [12/17] RUN /usr/local/go/bin/go install -v github.com/fatih/gomodifytags@v1.16.0 3.9s => [13/17] RUN /usr/local/go/bin/go install -v github.com/josharian/impl@v1.1.0 6.1s => [14/17] RUN /usr/local/go/bin/go install -v github.com/haya14busa/goplay/cmd/goplay@v1.0.0 2.8s => [15/17] RUN /usr/local/go/bin/go install -v github.com/haya14busa/goplay/cmd/goplay@v1.0.0 1.3s => [16/17] RUN /usr/local/go/bin/go install -v github.com/go-delve/delve/cmd/dlv@latest 15.3s => [17/17] RUN /usr/local/go/bin/go install -v honnef.co/go/tools/cmd/staticcheck@latest 10.9s => exporting to image 17.8s => => exporting layers 17.7s => => writing image sha256:65e6853e344db6a4256ec1d0eaca83124fab848935416a80e9ea4d951e3aeb03 0.0s => => naming to docker.io/library/throwable 0.0s

@caffeinated92 caffeinated92 requested a review from tanji May 26, 2024 09:13
@caffeinated92 caffeinated92 changed the title upgrade golang docker to 1.22 Bump golang docker to 1.22 May 26, 2024
@tanji tanji merged commit 18b10e8 into develop May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants