Feature request: Allow sharing Android calendar events via TextSecure

[dang357]

Originally a bug, which should have been titled "Shared calendar events are not actually attached." The fix in #1025 removed TS from the "share with" list of calendar events, so no longer a bug, but would like to be able to share calendar events via TS, same as can be done with default Android text app.

Original (bug) text: Android default Calendar app lets you send a calendar entry. TextSecure is one of the apps that comes up as an option to use for sending. Choosing it, you get to TextSecure, but there is no attachment, just an empty message. (If you choose the regular default Android Text Messaging app, the calendar entry does get properly attached, which is why I suspect the issue is with TextSecure.) Only tried doing this from Calendar, don't know if it's an issue sending via TextSecure from other apps.

[generalmanager]

I want to chime in here, because I haven't found anything about this anywhere else.
Sharing pictures from the gallery or anywhere else works great in 2.0.7.

But whenever I want to forward a message with an image, only the text gets into the new message. I kinda suspect 1025, but I'm not really sure it worked before the commit.
Observed behaviour: Forwarding messages with pictures only forwards the text.
Expected behaviour: Forwarding messages with pictures forwards the whole message.

[McLoo]

@generalmanager
The reason for your issue - which i confirm - is in ConversationFragment.java

  private void handleForwardMessage(MessageRecord message) {
    Intent composeIntent = new Intent(getActivity(), ShareActivity.class);
    composeIntent.putExtra(ConversationActivity.DRAFT_TEXT_EXTRA, message.getDisplayBody().toString());
    composeIntent.putExtra(ShareActivity.MASTER_SECRET_EXTRA, masterSecret);
    startActivity(composeIntent);
  }

Only the text is selected for forwarding.
You might want to open a new Issue for that as this is an internal action that has nothing to do with the original issue or #316 - if I'm not completely wrong.

[generalmanager]

@McLoo Thanks for checking this out! But I don't think opening another issue is the best way to go about it.
It appears to me that it'd be a rather small fix, this issues title fits the problem and there aren't already 10 other posts, which would certainly lower the visibility of the specific bug I'm talking about.
There are already over 480 open tickets, most of which are at least partial duplicates and I don't want to blow this number up any more than necessary ;-)

[McLoo]

I wonder if updates on such old issues get noticed though. Neither Moxie nor McGinty (avoided the @) are participants on this issue.

[generalmanager]

Yeah that may be a problem, but it worked out with #299 too. And this is not the most important feature/bug, so maybe it's not that bad if they get to the important stuff first ;-)

[DorianScholz]

@generalmanager: Unfortunately the bug you describe is not related to the original bug reported here. The title of this bug is simply to general and should actually read "Shared calendar events are not actually attached" (forwarding messages in TS is not related to the Android "share with" mechanism). The fix in #1025 removed TS from the "share with" list of calendar events, but is not related to forwarded image attachments at all.

As @McLoo suggested, a new issue should be opened with the title "When forwarding messages with attachments only the text is forwarded".

This issue should either be closed or retitled and changed into a feature request for sharing calendar events, which has to be done by the OP or a commiter (but I also don't want to draw more resources to this more or less obsolete bug...).

[dang357]

@DorianScholz: Revised title as per your suggestion & updated description using text from your comment, hope you don't mind. I didn't find a way to relabel it from bug to feature.

[DorianScholz]

@dang357: Perfect, thanks for the update, this should reduce confusion and hopefully lead to an implementation of the feature at some point.
@generalmanager: Thanks for the new issue.

[kalaspuffar]

@dang357: Looked at this issue a bit to see how hard an implementation of a sending of calendar event would be. And if you just want to read an event and send it to someone so they could have a similar event in their calendar that shouldn't be hard, might need to invent a lean format. But if you add them to it as a attendee for instance and use the regular Google Calendar then you already have this calendar in the cloud and most of the invitation messaging is done by Google so I'm not sure what the use case is for this feature. When you add a calendar event to your Google calendar it's already sent over the wire none encrypted.

Another thing is that this feature will add a requirement to the permissions so you can read the calendar. And perhaps this could be a bad for some users. "Why does this messaging app need to access my calendar?" someone might ask.

Then again I think it's up to moderators to decide if this is a feature worth looking into. @moxie0 @mcginty @agrajaghh @rhodey

[automated-signal]

GitHub Issue Cleanup:
See #7598 for more information.