-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Meteor0id enhance ringing sounds #12390
base: main
Are you sure you want to change the base?
Conversation
There are also two other files which could potentially be added to this PR but those would require some code changes:
Would be nice to add those too but if you end up just merging outgoing and busty sounds that's still a nice enhancement. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This isn't an issue, it's a PR. |
ha ha... The bot got his wires crossed 🤣 |
I've brought this up to design multiple times, it's in their court. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still no news from Design? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We seem to be getting a calls overhaul but the sound hasn't been touched upon yet.. I really hope they work on it since it's a stupidly simple task compared to all the awesome work they've done for calls in the current beta. |
Seen this feature request in the forum: How about the ringing sound of Signal Desktop? https://github.com/signalapp/Signal-Desktop/blob/main/sounds/ringtone_minimal.ogg Or sounds from Signal iOS? https://github.com/signalapp/Signal-iOS/blob/main/Signal/AudioFiles/ringback_tone_ansi.caf |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Such a simple fix, lets not waste it by ignoring it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
A comment for stalebot |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Kick |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signals noicy ribgtones still hurt my ears. I love the authentic old sound but the noice shouldn't be part if it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Why not test it in the next beta and get feedback from the beta testers? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Oh no, stale-bot. |
Contributor checklist
Description
PR with @Meteor0id improved sound files for outgoing and busy calling sound.
Learn more: #8948