-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for users to determine frequency of backup creation #13199
base: main
Are you sure you want to change the base?
Conversation
Also minor Kotlin cleanups
Yes I know this is bad practice but it's just for testing purposes
Rename OK button and add cancel button
Apparently it's a Unix timestamp in milliseconds and this took me way too long to figure out myself
When changing backup frequency settings, schedule the next backup using the new setting, but relative to the timestamp of the latest backup, instead of immediately. This ensures that backups are not created too frequently. A backup will only be immediately created if the latest backup was too long ago, relative to the new frequency setting, or if there is no latest backup.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
- Replace debug toast with debug log statement - Use MaterialAlertDialog instead of boring AlertDialog
Fixed the localisation issue. I have only added a string for English but at least there are resources now. |
Just because the plural has a single manifestation in English doesn't mean we don't need to have plurals for it in other languages.
Is there anything I can do to make this PR better? |
Added a video recording demonstrating the feature. (link) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@farewelltospring one suggestions, could you please add the option to put the number of days as an int (with sensible limits) as having to choose from a list feels arbitrary and might not cover all use cases, but I can totally understand if you keep it as is
|
Just caught wind of this commit - 49ba83d - is this PR able to be resolved? |
There's some kind of divergence in the parallel implementation that the people at Signal are doing instead of just merging my code (sadface), which caused some lossy merge conflicts. This fixes it and restores my version of slow backups to full functionality.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
This pull request allows users change the frequency that backups are made to a selected interval (weekly, monthly, quarterly, every 6 months, annually).
Currently, when backups are enabled, Signal will create a fresh backup every 24-hours. This causes unnecessary write cycles on the device's internal storage or SD card.
A setting to control the backup frequency would also give people more control over their data, which is an important value to cultivate in today's society.
Verified that this behaviour works by setting backup frequency to 30 days and then waiting that long to see if a backup got created (I restarted the device several times during that time period to verify that it persists).
Screen_recording_20240111_000341.mp4