Add support for searching emoji and reactions #13643
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
Is it quite convenient to react to messages I want to refer back to with specific emoji (such as 📌).
This PR adds the Unicode emoji character class to the message indexing filter, including emoji in messages in the search index.
It also includes reaction emoji as a separate column in the search index.
I tested adding, changing, and removing reactions to a message and the interaction with the search results. I also tested deleting a message with a reaction.
I am not clear how Signal updates its database after a schema change. This CR works for new installs but fullyResetTables needs to be called in the event the app is being updated.
If this is accepted I intend to cut another PR that will allow multiple different reactions to a message from the same sender*.