Remove junit.framework

[jamesonwilliams]

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution on these devices:

• Local development machine for JVM tests

• My contribution is fully baked and ready to be merged as is
• I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

---

Description

The junit.framework is leftover from JUnit 3, although most of the Android community uses the JUnit 4.x series. JUnit 4.x uses the import org.junit.

I did a global replace-all of some common junit.framework imports and replaced them with their org.junit analogs.

TestCase is a one special case; it is necessary to add @Test on functions in classes that wear extends TestCase.

In a few places I fixed the order of expected/actual calls to assertEquals(...) (again through a regular expression that automatically swapped them.)

In a few places I added assertThrows where there had been a try/catch construct used haphazardly instead

At the end of all this, this is the result:

$ rg junit\.framework
microbenchmark/benchmark-proguard-rules.pro:-dontnote junit.framework.**

Also, this passes:

./gradlew qa
[...snip...]
BUILD SUCCESSFUL in 3m 2s

[greyson-signal]

Awesome, thanks so much! I'll sleep happier knowing I won't have to remember which assert to import :)