Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the last batch of Mockito/Java tests to Kotlin/MockK #13829

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jamesonwilliams
Copy link
Contributor

Contributor checklist

  • M3 MacBook Pro
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This migrates the last batch of Java tests using Mockito towards Kotlin/MockK. After this, some Kotlin tests still use Mockito, but there are no more Java tests that use Mockito.

  • CallParticipantListUpdateTest
  • UnarchivedConversationListDataSourceTest
  • JobManagerFactoriesTest
  • RecipientIdCacheTest
  • StorageSyncHelperTest
  • SecureRandomTestUtil

Testing

./gradlew qa still passes

@greyson-signal
Copy link
Contributor

Awesome, thank you! Honestly Mockito is one of the biggest annoyances I run into when having to update code with older tests. This is a big help, and it'll be great when we can remove it altogether!

@jamesonwilliams
Copy link
Contributor Author

it'll be great when we can remove it altogether!

Awesome, I'll keep hunting down this goal, then; there's only a few dozen Kotlin tests left using Mockito. I can probably get rid of it within a few more batched migration PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants