Move avatars to toolbar in individual convos

[mhernz]

// FREEBIE

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution on these devices:

• OnePlus 3T, Android 7.1.1
• AVDs, Android 7.1.1/Android 4.4.2

• My contribution is fully baked and ready to be merged as is
• I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax
• I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in the commit message of my first commit

---

Description

A picture is worth a thousand words:

Before	After

Fixes #6008

[paride]

It seems to me that a lot of space is wasted between the "back" arrow and the avatar. Do we really need that arrow? The "back" (software) button does the same thing.

[RiseT]

I'm in favor of that arrow, but agree that there's a lot of space wasted between the arrow and the avatar. Is this spacing defined by some Material guideline?

[mhernz]

Yes, the extra padding is supposed to be there to increase the touch target of the back button.

[rainerzufall]

What I personally find odd, is the extended empty space in the green bubble (to the right side of the text in the after screenshot). Is this intentional? It seems that the bubble, after removing the avatar, could display more words per line. Like the white bubble already does.

[RiseT]

@rainerzufall I guess that's because the first words of each line are too long in this example so they cannot get "unwrapped", i. e. moved into the respective prior line.

[paride]

@mateoeh Still, I think the spacing around the arrow is a bit odd. For example I think it would look better if the space on the right was equal to the space on the left. Even like this it could be a problem on low resolution devices. Maybe it's possible to make the arrow disappear if the avatar contact's name can't be displayed completely?

What about replacing the arrow with a "swipe to go back" gesture?

[moxie0]

Thanks but I don't want to make this change at this time. We'll revisit after some future changes are in.

[lokesh-krishna]

@moxie0 Could you please share what other changes are required for this to get merged so that @mateoeh or somebody else could work on them to expedite this?

[lokesh-krishna]

@moxie0 Are the changes in v4.9 (which shows up as major internal database changes on the Play Store changelog) the ones you were referring to? If so then can this be reconsidered now?