Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that local number is always a member of MMS groups #8296

Closed
wants to merge 1 commit into from
Closed

Ensure that local number is always a member of MMS groups #8296

wants to merge 1 commit into from

Conversation

dwong
Copy link

@dwong dwong commented Oct 21, 2018

Fixes #7683

Contributor checklist

  • Samsung Galaxy S9, Android 8.0.0
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

New MMS groups do not initially have the local number as a member. As stated in the bug report #7683, this caused subsequent responses to create a new group since the membership is different.

Signal should behave similar for non-secure MMS groups as it does for Signal groups: the local number should always be a member of the group.

Tested this by:

  1. Creating an MMS group from Signal
  2. Receive response from another member
  3. Verify that the group is properly threaded
    screenshot_20181021-145212_signal
    screenshot_20181021-145223_signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New MMS group created for responses to a group created through signal
2 participants