Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
if(MessageDigest.isEqual(ourMac, theirMac)
was always returning false sinceourMac
was of length 32 andtheirMac
was of length 10.This issue most likely went under the radar since a
!
was forgotten in the condition.I'm also not sure of what happens when an exception is thrown in case of a MAC missmatch to the output stream in
readAttachmentTo(OutputStream out, int length)
. There is aout.close()
before the check, the file is written even if an exception is raised ?